-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing window border when use "win+arrow down" in fullscreen mode in Terminal #11653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wild. Makes sense to me. Thanks for doing this!
If you want to send another PR, that would be best! Conhost changes are easier to review in isolation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you!
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This PR causes build errors, because, when combined with #11404, terminal/src/cascadia/WindowsTerminal/IslandWindow.cpp Lines 609 to 631 in 7aae2e9
|
🎉 Handy links: |
🎉 Handy links: |
Window sends an event that requests exit from fullscreen then SC_RESTORE messages is sent and it is in fullscreen mode.
Closes #10607
Validation Steps Performed
Border and tabbar now appear after exiting fullscreen via "win+arrow down".