-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --elevate
flag
#12142
Add a --elevate
flag
#12142
Conversation
``` git diff dev/migrie/f/non-terminal-content-elevation-warning dev/migrie/f/632-on-warning-dialog > ..\632.patch git apply ..\632.patch --ignore-whitespace --reject ```
To match the arg in #12137. `--elevate` will manually elevate the profile. `--no-elevate` will override a `elevate: true` in the profile with false. So now you can `wt --elevate cmd` and it'll do what you think * [x] I work here * [x] Tests added * [ ] need to update docs
@zadjii-msft Curious, what happens when somebody puts |
dont merge this quite yet |
If the Terminal isn't already running, and you have a saved layout, then this line right here crashes with a |
Okay before I lose it
|
Ho boy, this just got interesting. Consider:
you'd assume that would spawn two tabs elevated (in the same window), even with glomming turned off. That's not what would happen. We'd spawn one May have to reconsider this entirely. Might have to become a root-level parameter, to affect the entire commandline. E.g. "run this commandline in and elevated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll block you just in case
Ah butts okay. I definitely need to turn this into a top-level flag, not a I'm going to just close this for now, and file proper issues for both these to keep me honest. |
To match the arg in #12137.
--elevate
will manually elevate the profile.--no-elevate
will override aelevate: true
in the profile with false.So now you can
wt --elevate cmd
and it'll do what you think