Autocomplete keyframe animations when occluded on Windows 11 #12820
Conversation
On certain builds of Windows, when Terminal is set as the default it will accumulate an unbounded amount of queued animations while the screen is off and it is servicing window management for console applications. This results in Terminal hanging when left overnight, as it has millions of animations to process. The new call into TerminalThemeHelpers will tell our compositor to automatically complete animations that are scheduled while the screen is off. Fixes MSFT-38506980
|
For servicing, this actually needs custom conflict resolution since this PR is built on the Common Nuget infrastructure. |
| @@ -399,6 +401,15 @@ void AppHost::Initialize() | |||
| _revokers.OpenSystemMenu = _logic.OpenSystemMenu(winrt::auto_revoke, { this, &AppHost::_OpenSystemMenu }); | |||
| _revokers.QuitRequested = _logic.QuitRequested(winrt::auto_revoke, { this, &AppHost::_RequestQuitAll }); | |||
|
|
|||
| // BODGY | |||
There was a problem hiding this comment.
Do we have a MSFT:xxx ticket to track this with?
There was a problem hiding this comment.
Nope. I'm following the linked ^^ bug from the PR body
|
@msftbot merge this in 3 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit On certain builds of Windows, when Terminal is set as the default it will accumulate an unbounded amount of queued animations while the screen is off and it is servicing window management for console applications. This results in Terminal hanging when left overnight, as it has millions of animations to process. The new call into TerminalThemeHelpers will tell our compositor to automatically complete animations that are scheduled while the screen is off. Fixes MSFT-38506980 (cherry picked from commit 8405c7a) Service-Card-Id: 80150451 Service-Version: 1.13
On certain builds of Windows, when Terminal is set as the default it will accumulate an unbounded amount of queued animations while the screen is off and it is servicing window management for console applications. This results in Terminal hanging when left overnight, as it has millions of animations to process. The new call into TerminalThemeHelpers will tell our compositor to automatically complete animations that are scheduled while the screen is off. Fixes MSFT-38506980 (cherry picked from commit 8405c7a) Service-Card-Id: 80150450 Service-Version: 1.12
DHowett
added
Priority-1
|
🎉 Handy links: |
|
🎉 Handy links: |
On certain builds of Windows, when Terminal is set as the default it
will accumulate an unbounded amount of queued animations while the
screen is off and it is servicing window management for console
applications.
This results in Terminal hanging when left overnight, as it has millions
of animations to process.
The new call into TerminalThemeHelpers will tell our compositor to
automatically complete animations that are scheduled while the screen is
off.
Fixes MSFT-38506980