Replace RadioButton expanders with ComboBoxes
#12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings UI
DHowett
reviewed
Apr 5, 2022
DHowett
reviewed
Apr 5, 2022
lhecker
approved these changes
Apr 5, 2022
Looks good to me. So much better than before. Thank you! |
carlos-zamora
requested changes
Apr 5, 2022
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This was referenced May 2, 2022
6 tasks
carlos-zamora
pushed a commit
that referenced
this pull request
May 12, 2022
Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d ### Checklist * [x] Closes #12648 * [x] Actually closes #9566 as well (by just removing all radio buttons) * [x] I work here * [x] Tested manually * [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not. ### Before, after:  (cherry picked from commit 9e03800) Service-Card-Id: 81744877 Service-Version: 1.13
|
🎉 Handy links: |
This was referenced May 24, 2022
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all the
RadioButtonexpanders withComboBoxes, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77dChecklist
Before, after: