Change TSFInputControl inputScope to AlphanumericHalfWidth #13028
Conversation
Change TSFInputControl inputScope to AlphanumericHalfWidth. This should improve user friendliness for users using composition mode input methods.
ghost
added
Area-i18n
There was a problem hiding this comment.
You've got solid notes in #12731, so I'm cool with this. Thanks for taking the time to look into this! I know I sure learned something new 😄
DHowett
changed the title
|
Thank you! |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 37 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 1 minute |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
…icrosoft#13028)" This reverts commit 6e87e0b.
…icrosoft#13028)" This reverts commit 6e87e0b.
Modified the scope of input control, it used to be
Text, now it isAlphanumericHalfWidth. This input scope actually accepts anycharacters, but English characters are preferred, and the soft keyboard
also displays English by default.
This should improve user friendliness for users using composition mode
input methods.
As a user who uses the composition mode input method, in applications
like windows terminal that should usually be input in English, it is
always required to manually switch to English mode by pressing Shift
before entering commands.
One keystroke is not a problem, but often for some reason there is no or
no successful switching, and additional more keystrokes are required to
clear the wrong input.
The input method that comes with windows will automatically switch to
English mode for a few programs such as conhost, but windows terminal is
not in this list.
This change should have no negative impact. Even if someone does tend to
use a shell oriented towards composition characters or non-alpha
letters, there should also were more users who in the same language are
more inclined to English characters shells, for example, cmd,
powershell, bash that comes with windows.
If there's any reason to have to keep the Text inputScope, maybe making
this setting customizable via
settings.jsonwould be a good idea, butI don't see the need to do this,
AlphanumericHalfWidthis perfect.Closes #12731