Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP for adding BellSound to schema #13035

Merged
merged 7 commits into from
May 10, 2022
Merged

WIP for adding BellSound to schema #13035

merged 7 commits into from
May 10, 2022

Conversation

pizzaz93
Copy link
Contributor

@pizzaz93 pizzaz93 commented May 4, 2022

PR Checklist

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels May 4, 2022
@pizzaz93
Copy link
Contributor Author

pizzaz93 commented May 4, 2022

I'm not sure what the default is and the regex for the pattern?
Additional questions would be about the placement of BellSound within the schema and if there are additional fields that should be added.

carlos-zamora
carlos-zamora requested changes May 5, 2022
View reviewed changes
doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 5, 2022
@pizzaz93 @carlos-zamora
Apply suggestions from code review
6dde003 
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 6, 2022
@pizzaz93 pizzaz93 requested a review from carlos-zamora May 6, 2022 16:29
carlos-zamora
carlos-zamora requested changes May 6, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few things and I'm ready to hit that ✅! 😊

doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 6, 2022
@pizzaz93 @carlos-zamora
Apply suggestions from code review
ef7e39d 
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 6, 2022
@pizzaz93 pizzaz93 requested a review from carlos-zamora May 6, 2022 19:25
carlos-zamora
carlos-zamora approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for doing this!

doc/cascadia/profiles.schema.json Outdated Show resolved Hide resolved
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label May 6, 2022
@ghost ghost requested review from zadjii-msft, PankajBhojwani, DHowett and lhecker May 6, 2022 20:23
@pizzaz93 @carlos-zamora
Update doc/cascadia/profiles.schema.json
c151289 
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
@pizzaz93
Copy link
Contributor Author

pizzaz93 commented May 6, 2022

Awesome. Thanks for doing this!

You're very welcome, glad to help.

DHowett
DHowett approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DHowett
Copy link
Member

DHowett commented May 6, 2022

@msftbot merge this in 2 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 6, 2022
@ghost
Copy link

ghost commented May 6, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 06 May 2022 22:45:50 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett
Copy link
Member

DHowett commented May 6, 2022

Oh, it is a schema update. The bot will never merge it.

@DHowett DHowett merged commit 171524d into microsoft:main May 10, 2022
@pizzaz93 pizzaz93 deleted the patch-1 branch May 10, 2022 18:05
carlos-zamora pushed a commit that referenced this pull request May 12, 2022
@pizzaz93 @carlos-zamora
Add BellSound to the schema (#13035)
196f77d 
Closes #12504

(cherry picked from commit 171524d)
Service-Card-Id: 81603561
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal v1.13.1143 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 24, 2022
Closed
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Jul 5, 2022
Merged
Merged
DHowett pushed a commit that referenced this pull request Jul 5, 2022
@zadjii-msft
Fix the bellsound schema, for real (#13433)
86dfefa 
As noted in #11511 (comment).

Missed in #13035
DHowett pushed a commit that referenced this pull request Jul 5, 2022
@zadjii-msft @DHowett
Fix the bellsound schema, for real (#13433)
e5239f8 
As noted in #11511 (comment).

Missed in #13035

(cherry picked from commit 86dfefa)
Service-Card-Id: 83891742
Service-Version: 1.14
DHowett pushed a commit that referenced this pull request Jul 5, 2022
@zadjii-msft @DHowett
Fix the bellsound schema, for real (#13433)
0080b81 
As noted in #11511 (comment).

Missed in #13035

(cherry picked from commit 86dfefa)
Service-Card-Id: 83891743
Service-Version: 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bellSound missing from JSON schema
3 participants
@pizzaz93 @DHowett @carlos-zamora