Stop the viewport being moved when in the alt buffer #13039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When
TerminalDispatch
was merged withAdaptDispatch
in PR #13024,that broke the Terminal's
EraseAll
operation in the alt buffer. Theproblem was that the
EraseAll
implementation makes a call toSetViewportPosition
which wasn't taking the alt buffer into account,and thus modified the main viewport instead.
This PR corrects that mistake. If we're in the alt buffer, the
SetViewportPosition
method now does nothing, since the alt bufferviewport should always be at 0,0.
References
This was a regression introduced in PR #13024.
PR Checklist
Validation Steps Performed
I've confirmed that the test case reported in issue #13038 is no longer
failing. I've also made sure the
ED 2
andED 3
sequences are stillworking correctly in the main buffer.