Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] Move scroll mark settings from global to profile settings #13655

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

carlos-zamora
Copy link
Member

Updates the schema such that the scroll mark settings are defined as profile settings instead of global settings (because they're actually profile settings).

Separately (but still relevant), I've also updated the release notes.

Closes #13583

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Aug 2, 2022
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Aug 2, 2022
@ghost ghost requested review from PankajBhojwani, DHowett and lhecker August 2, 2022 16:59
@carlos-zamora carlos-zamora merged commit 61d84a7 into main Aug 2, 2022
@carlos-zamora carlos-zamora deleted the dev/cazamor/scroll-marks-schema branch August 2, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental "marks" settings are documented as global, but are per-profile
3 participants