-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color chips to the color scheme dropdown in Appearance #14587
Conversation
Since the XAML is very similar to that of the color schemes page, is there any way we can deduplicate the code? Maybe introduce something similar to |
oh it's so pretty |
Since the values are slightly different between the two UIs (namely the sizes/spacings), we will need 2 separate styles, one for the color schemes list view and one for the color schemes combo box.... This means we are simply moving the code duplication from one place to another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, the deduplication of code seems like a decent amount of extra work for little gain. I don't even know if it's worth filing a follow-up. If anybody else agrees, sure. But I don't think it's worth blocking over.
Excited to see this merge!
Wow, that other PR made this one super easy |
Bug Bash Feedback:
|
We can change the However, for some reason this does not translate over to when the |
@@ -54,6 +54,7 @@ | |||
SettingOverrideSource="{x:Bind Appearance.DarkColorSchemeNameOverrideSource, Mode=OneWay}"> | |||
<ComboBox ItemsSource="{x:Bind Appearance.SchemesList, Mode=OneWay}" | |||
SelectedItem="{x:Bind Appearance.CurrentColorScheme, Mode=TwoWay}" | |||
Padding="4" | |||
Style="{StaticResource ComboBoxSettingStyle}"> | |||
<ComboBox.ItemTemplate> | |||
<DataTemplate x:DataType="local:ColorSchemeViewModel"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was thinking more like, we could reduce the inner padding inside the grid to generally tighten it up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah, it looks fine. let's ship it.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
Does what it says on the tin.