-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the win10/win11 digit from our version number. #14660
Conversation
The original author of that thread brought up a fair consideration: that version number is required, and we will have to talk about it sometimes, because it's the package version on disk. System builders/distributors will need to know the "real" number, and the filenames will contain it too. How do we square those things? |
That's a good question. I don't know. Hover the short version to reveal the full version string? Bold this part of the string, but show the rest at normal font weight? |
@DHowett I'm gonna hand this one to you for the 1.17 call. If you want to sort out this for 1.17, That's cool. Otherwise I don't mind punting on this decision for another release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh, I'm okay with this.
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
We ship a separate package to Windows 10, which contains a copy of XAML embedded in it, because of a bug in activating classes from framework packages while we're elevated. We did this to avoid wasting disk space on Windows 11 installs (which is critical given that we're preinstalled in the Windows image.) The fix for this issue was released in a servicing update in April 2022. Thanks to KB5011831, we no longer need this workaround! And finally, this means that we no longer need to depend on a copy of "pre-release" XAML. We only did that because it would copy all of its assets into our package. Introduced in #12560 Closes #14106 Closes (discussion) #14981 Reverts #14660
We ship a separate package to Windows 10, which contains a copy of XAML embedded in it, because of a bug in activating classes from framework packages while we're elevated. We did this to avoid wasting disk space on Windows 11 installs (which is critical given that we're preinstalled in the Windows image.) The fix for this issue was released in a servicing update in April 2022. Thanks to KB5011831, we no longer need this workaround! And finally, this means that we no longer need to depend on a copy of "pre-release" XAML. We only did that because it would copy all of its assets into our package. Introduced in #12560 Closes #14106 Closes (discussion) #14981 Reverts #14660 (cherry picked from commit f5e9e8e) Service-Card-Id: 88600517 Service-Version: 1.17
As of about 2022, the one's digit of the Build of our version is a placeholder value to differentiate the Windows 10 build from the Windows 11 build. Let's trim that out, it's only a source of confusion.
For additional clarity, let's omit the Revision, which must be
.0
, and doesn't provide any value to report.We will need to make sure we report releases as
1.17.ABC
now, instead of1.17.ABC1.0
/1.17.ABC2.0
Let's not backport this. 1.17 will be the start of the new numbering scheme. Otherwise,
1.16.EFG
<1.16.ABC1.0
, for an old versionABC1
and a new versionEFG
.