Fix the selected color scheme list item container background being blue in Windows 10 #14706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Win 11: |
zadjii-msft
approved these changes
Jan 19, 2023
carlos-zamora
approved these changes
Jan 19, 2023
| @@ -70,6 +70,9 @@ | |||
| PreviewKeyDown="ListView_PreviewKeyDown" | |||
| SelectedItem="{x:Bind ViewModel.CurrentScheme, Mode=TwoWay}" | |||
| SelectionMode="Single"> | |||
| <ListView.Resources> | |||
| <SolidColorBrush x:Key="ListViewItemBackgroundSelected" Color="{ThemeResource SystemListLowColor}" /> | |||
There was a problem hiding this comment.
nit: I would mention that we need to do this because of Win10
DHowett
requested changes
Jan 19, 2023
ghost
added
the
Needs-Author-Feedback
|
Win 10: |
ghost
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Jan 19, 2023
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the resource to use for the list view item background when selected.
References #14693
Validation Steps Performed
Background is no longer blue, it is light gray (like in Windows 11). Screenshots below.