Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TranslateUnicodeToOem and all related code #14745

Merged
merged 12 commits into from
Feb 28, 2023
Merged

Remove TranslateUnicodeToOem and all related code #14745

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b5b96d
Excise TranslateUnicodeToOem and everything it touched
lhecker Jan 27, 2023
819febe
Fix build
lhecker Jan 27, 2023
ac1f371
Merge remote-tracking branch 'origin/main' into dev/lhecker/8000-Tran…
lhecker Feb 3, 2023
caba56d
Rewrite half InputBuffer
lhecker Feb 3, 2023
eac0aeb
Remove previously added code
lhecker Feb 3, 2023
005bc21
Address feedback
lhecker Feb 3, 2023
738ce5f
Simplify InputBuffer::Read and fix KeyEvent repeats
lhecker Feb 5, 2023
a0f1637
Fix zero initialization
lhecker Feb 5, 2023
d3ca747
Fix CRLF
lhecker Feb 6, 2023
3d14766
Merge remote-tracking branch 'origin/main' into dev/lhecker/8000-Tran…
lhecker Feb 28, 2023
7d9a213
Address feedback
lhecker Feb 28, 2023
ee2850d
Fix bad merge
lhecker Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/host/readDataDirect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ try
}
catch (...)
{
// There doesn't seem to be a way to just get the NT exception code with WIL.
*pReplyStatus = NTSTATUS_FROM_HRESULT(wil::ResultFromCaughtException());
*pReplyStatus = wil::StatusFromCaughtException();
return true;
}

Expand Down
15 changes: 4 additions & 11 deletions src/inc/til/type_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,14 @@ namespace til
struct is_contiguous_view : std::false_type
{
};
// std::span remains largely unused in this code base so far.
//template<typename U, std::size_t E>
//struct is_contiguous_view<std::span<U, E>> : std::true_type
//{
//};
template<typename U, typename V>
struct is_contiguous_view<std::basic_string_view<U, V>> : std::true_type
{
};
#ifdef GSL_SPAN_H
template<typename U, std::size_t E>
struct is_contiguous_view<std::span<U, E>> : std::true_type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rofl, oops

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah woops. 😅 Well, problem fixed!

{
};
#endif
template<typename U, typename V>
struct is_contiguous_view<std::basic_string_view<U, V>> : std::true_type
{
};

template<typename T>
struct is_byte : std::false_type
Expand Down