Minor improvements for SplitToOem #14746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #14745 I noticed that
SplitToOem
was in a bit of a poor stateas well. Instead of simply iterating over its
deque
argument and writing theresults into a new
deque
it usedpop
to advance the head of both queues.This isn't quite exception safe and rather bloaty. Additionally there's no need
to call
WideCharToMultiByte
twice on each character if we know that the mostverbose encoding is UTF-8 which can't be any more than 4 chars anyways.
Related to #8000.
PR Checklist