Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KeyEvent char data a little less confusing #14747

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Make KeyEvent char data a little less confusing #14747

merged 2 commits into from
Feb 2, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jan 27, 2023

When working on #14745 I found KeyEvents a little hard to read in the
debugger. I noticed that this is because of sign extension when converting
chars to wchar_ts in KeyEvent::SetCharData.

@lhecker lhecker added AutoMerge Marked for automatic merge by the bot when requirements are met Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Feb 2, 2023
@carlos-zamora carlos-zamora merged commit ddc349b into main Feb 2, 2023
@carlos-zamora carlos-zamora deleted the dev/lhecker/8000-KeyEvent-CharData branch February 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhecker @DHowett @carlos-zamora @zadjii-msft