Update tab drop behavior to select dropped tab #14787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PankajBhojwani
approved these changes
Feb 7, 2023
carlos-zamora
approved these changes
Feb 7, 2023
carlos-zamora
added
the
AutoMerge
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Interesting. Looking at how Edge/Chrome/Firefox handle this, the tab is selected immediately on [Mouse Down Inside] whereas in XAML TabView it's selected on [Mouse Up]. That's the real culprit here...
I'm not averse to making this work the way it should, but it does suggest that we should also file a bug upstream. 😄
|
Thank you for implementing this change, @chingucoding ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragging and dropping tabs now selects them
Closes #12473