Remove useRegExe and add rescap:unvirtualizedResources #15028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a limitation in the Windows App Installer UI, Terminal had to shell out to `reg.exe` to write the Delegation registry keys. The team in charge of AppInstaller lifted that (once by-policy) limitation. Therefore, we can remove our BODGY workaround.
miniksa
approved these changes
Mar 21, 2023
|
Evinced by my branch name, "unbodge for once" |
|
If the computer has an old version of App Installer that does not include the fix, and Windows Terminal is installed from Microsoft Store (not by double-clicking an MSIX file), then will it register correctly? |
|
Oh, absolutely. The only thing that stopped us from doing this before was that double-clicking an MSIX presented a UI that said "You are not under any circumstances allowed to install this app by double-clicking it." Store deployment and |
zadjii-msft
approved these changes
Mar 21, 2023
DHowett
added a commit
that referenced
this pull request
Mar 31, 2023
Due to a limitation in the Windows App Installer UI, Terminal had to shell out to `reg.exe` to write the Delegation registry keys. The team in charge of AppInstaller lifted that (once by-policy) limitation. Therefore, we can remove our BODGY workaround. (cherry picked from commit e0046a4) Service-Card-Id: 88581048 Service-Version: 1.17
|
I want to leave a message for asking how to apply Thanks if I get the reply. Kenji Mouri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a limitation in the Windows App Installer UI, Terminal had to shell out to
reg.exeto write the Delegation registry keys. The team in charge of AppInstaller lifted that (once by-policy) limitation.Therefore, we can remove our BODGY workaround.