Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually hide our DesktopWindowXamlSource #15165

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Manually hide our DesktopWindowXamlSource #15165

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7edd442
Manually hide our DesktopWindowXamlSource
zadjii-msft Apr 11, 2023
d14e622
Merge branch 'main' into dev/migrie/b/6507-DesktopWindowXamlSource
zadjii-msft Apr 12, 2023
5523e44
after talking with XAML folks, this is the solution
zadjii-msft Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cascadia/WindowsTerminal/IslandWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,11 @@ void IslandWindow::Initialize()
// stash the child interop handle so we can resize it when the main hwnd is resized
interop->get_WindowHandle(&_interopWindowHandle);

// Immediately hide our XAML island hwnd. On earlier versions of Windows,
// this HWND could sometimes appear as an actual window in the taskbar
// without this!
ShowWindow(_interopWindowHandle, SW_HIDE);

_rootGrid = winrt::Windows::UI::Xaml::Controls::Grid();
_source.Content(_rootGrid);

Expand Down