Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automation heading level 1 to fix about dialog #15200

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add automation heading level 1 to fix about dialog #15200

merged 3 commits into from
Apr 20, 2023

Conversation

BenConstable9
Copy link
Contributor

@BenConstable9 BenConstable9 commented Apr 18, 2023 •
edited by DHowett
Loading

Add automation heading level 1 to fix the about dialog by adding an automation property.

Allows screen reader to pick up that this is a heading and read properly.

Closes #11912

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 18, 2023
zadjii-msft
zadjii-msft approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably need to run the script tools\runxamlformat.cmd to make the CI happy, but if this works, I'\m good with it. Thanks!

@BenConstable9
Copy link
Contributor Author

You'll probably need to run the script tools\runxamlformat.cmd to make the CI happy, but if this works, I'\m good with it. Thanks!

I'll format it this week and validate once more :)

DHowett
DHowett approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow! Thanks for doing this.

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 20, 2023 12:44
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ffda8c4 into microsoft:main Apr 20, 2023
DHowett pushed a commit that referenced this pull request Apr 25, 2023
@BenConstable9 @zadjii-msft @DHowett
Add automation heading level 1 to fix about dialog (#15200)
57264e0 
Add automation heading level 1 to fix the about dialog by adding an
automation property.

Allows screen reader to pick up that this is a heading and read
properly.

Closes #11912

---------

Co-authored-by: Mike Griese <migrie@microsoft.com>
(cherry picked from commit ffda8c4)
Service-Card-Id: 89001995
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[About Dialog]: 'About' text which is visually appearing as heading is not defined in heading.
3 participants
@BenConstable9 @DHowett @zadjii-msft