Don't even try to MoveContent to the same window you started in #15325
Conversation
[Just don't go](https://youtu.be/jmIFwSKnuRM?t=102) Tracked in #14957
| // if the windowId is the same as our name, do nothing | ||
| if (windowId == WindowProperties().WindowName() || | ||
| windowId == winrt::to_hstring(WindowProperties().WindowId())) |
There was a problem hiding this comment.
Hmmmmm okay, but it does feel a bit weird
There was a problem hiding this comment.
Can you explain why it needs to compare against both properties? I don't quite get that...
There was a problem hiding this comment.
@lhecker so, the deal is that we generally treat "window" as a stealth union. Users can either specify a window name or a window ID in that property. So actions like
{ "keys": "f1", "command": { "action": "moveTab", "window": "1" }, },
{ "keys": "f2", "command": { "action": "moveTab", "window": "foo" }, },both work.
We don't know whether the string was the ID, or the name, so we have to check both.
There was a problem hiding this comment.
😢 why can't we just be like, if(this == otherwindae)
| @@ -1351,7 +1353,7 @@ void AppHost::_handleMoveContent(const winrt::Windows::Foundation::IInspectable& | |||
| windowBoundsReference = inDips.to_winrt_rect(); | |||
| } | |||
|
|
|||
| _windowManager.RequestMoveContent(args.Window(), args.Content(), args.TabIndex(), windowBoundsReference); | |||
| _windowManager.RequestMoveContent(targetWindow, args.Content(), args.TabIndex(), windowBoundsReference); | |||
There was a problem hiding this comment.
This change seems unrelated? The previous code had the benefit that the 3 args arguments map more clearly to the function call.
There was a problem hiding this comment.
op yea that was a side effect of the first attempt at a fix
DHowett
changed the title
Don't go.
Tracked in #14957