Restore the tab padding #15339
Merged
Restore the tab padding #15339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
approved these changes
May 12, 2023
DHowett
reviewed
May 12, 2023
| @@ -45,7 +45,7 @@ | |||
| Color="{ThemeResource SystemErrorTextColor}" /> | |||
|
|
|||
| <!-- Suppress top padding --> | |||
| <Thickness x:Key="TabViewHeaderPadding">9,0,5,0</Thickness> | |||
| <Thickness x:Key="TabViewHeaderPadding">0,0,0,0</Thickness> | |||
There was a problem hiding this comment.
removing the right padding - worth making sure about the sice when the tab bar is full-width
There was a problem hiding this comment.
I cannot figure out what the right padding was for. It looks the same here as in 1.18.1291 (and this PR isn't in that build)
DHowett
reviewed
May 12, 2023
| @@ -146,7 +146,7 @@ | |||
| --> | |||
| <x:Double x:Key="CaptionButtonHeightWindowed">40.0</x:Double> | |||
| <!-- 32 + (1 to compensate for GH#10746) + (-1 for GH#15164) --> | |||
| <x:Double x:Key="CaptionButtonHeightMaximized">33.0</x:Double> | |||
| <x:Double x:Key="CaptionButtonHeightMaximized">32.0</x:Double> | |||
DHowett
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, I don't really know where it regressed. There isn't time for me to go digging.
See also
Closes #15326