Reword or remove a bunch of subheadings in the SUI #15362
Conversation
| @@ -987,8 +971,8 @@ | |||
| <comment>Header for a control to toggle classic CRT display effects, which gives the terminal a retro look.</comment> | |||
| </data> | |||
| <data name="Profile_RetroTerminalEffect.HelpText" xml:space="preserve"> | |||
| <value>When enabled, enables retro terminal effects such as glowing text and scan lines.</value> | |||
| <value>Sets an override for the app's preferred language.</value> | ||
| <comment>A description explaining how this control changes the app's language.</comment> | ||
| <value>Selects a display language for the application. This will override your default Windows interface language.</value> | ||
| <comment>A description explaining how this control changes the app's language. {Locked="Windows"}</comment> |
There was a problem hiding this comment.
I'm not 100% if Windows is "Windows" in all languages. The Hindi Wikipedia article for instance is माइक्रोसॉफ्ट विंडोज़ ("maikrosopht vindoz").
There was a problem hiding this comment.
fair, but I think we have locked Windows elsewhere in the code. hmm.
| @@ -895,7 +879,7 @@ | |||
| <comment>Header for a control that sets the text line height.</comment> | |||
| </data> | |||
| <data name="Profile_LineHeight.HelpText" xml:space="preserve"> | |||
| <value>Sets the height of each line in the terminal as a multiple of the font size. The default depends on your font and is usually around 1.2.</value> | |||
| <value>Override the height of a line of text in the terminal. Measured as a multiple of the font size. The default value depends on your font, and is usually around 1.2.</value> | |||
There was a problem hiding this comment.
"a line"? There are many lines. 🤔 Given CSS and Word, I think "line height" as a term is fine.
There was a problem hiding this comment.
but it also doesn't set the height of each line, it sets the height of all lines. hmm
There was a problem hiding this comment.
MDN calls it "a line box"!
There was a problem hiding this comment.
but it also doesn't set the height of each line, it sets the height of all lines. hmm
What's the difference between those? 😵💫
There was a problem hiding this comment.
It's not a language thing, it's more of a feel thing. "Setting the height of each line" suggests to me that you could say "line 1 is this tall, line 2 however is THAT tall, etc etc".
It's very minor, and it is probably ENTIRELY in my head :D
There was a problem hiding this comment.
Oh, you meant the old text. I had a simpler form in mind:
Sets the line height of the terminal as a multiple of the font size.
Or, merged with your PR:
Override the line height of the terminal.
There was a problem hiding this comment.
OH. Yeah, totally. Thanks XD
| @@ -987,8 +971,8 @@ | |||
| <comment>Header for a control to toggle classic CRT display effects, which gives the terminal a retro look.</comment> | |||
| </data> | |||
| <data name="Profile_RetroTerminalEffect.HelpText" xml:space="preserve"> | |||
| <value>When enabled, enables retro terminal effects such as glowing text and scan lines.</value> | |||
| <comment>A description for what the "retro terminal effects" setting does. Presented near "Profile_RetroTerminalEffect".</comment> | |||
| <value>Show "retro" terminal effects such as glowing text and scan lines.</value> | |||
There was a problem hiding this comment.
I think "retro-style" would be better than quoting the word "retro". It also seems like this translates better into other languages (judging by Google Translate).
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
| @@ -1055,8 +1039,8 @@ | |||
| <comment>Header for a control to toggle changes in the app title.</comment> | |||
| </data> | |||
| <data name="Profile_SuppressApplicationTitle.HelpText" xml:space="preserve"> | |||
| <value>Use the tab title to override the default title of the tab and suppress any title change messages from the application.</value> | |||
| <comment>A description for what the "suppress application title" setting does. Presented near "Profile_SuppressApplicationTitle".</comment> | |||
| <value>Ignore application requests to change the title using OSC 2.</value> | |||
There was a problem hiding this comment.
Maybe we can add a little more here like "using the OSC 2 Virtual Terminal Sequence" so the user has something to work with if they don't understand what "OSC 2" means.
There was a problem hiding this comment.
that may be harder to translate, and there is not a hugely accepted vocabulary about what these are actually called. Technically, "in-band control sequences"... but also OSC is "operating system control", so the "operating system control control sequence". But also, it doesn't use CSI - which is the "Control Sequence Introducer"? It's complicated!
There was a problem hiding this comment.
I'd personally write
Ignore application requests to change the title (OSC 2).
I feel like saying that it's a VT sequence or only OSC 2 doesn't really add anything to the idea of "prevent title changes". Especially since SetWindowText is not OSC 2 - it just so happens that we translate it to OSC 2 in ConPTY which is sort of an implementation detail of WT from a user perspective. 🤔 I would personally only add the "OSC 2" in parenthesis at the end, because it might help with google-ing it.
There was a problem hiding this comment.
Not saying anything related to VT sequences doesn't help with looking it up online - try searching for "OSC 2" and see the results. That's why I'd like some sort of extra explanation/context so users can try to search for what it means
There was a problem hiding this comment.
To be fair, on its own it doesn't find much... but terminal osc 2 sure does.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Some of these were reundant, and some didn't feel right when I read them. Oh, and I got rid of all of these particularly unhelpful or non-additive resources: ``` Color Scheme [ v ] Is a color scheme ``` (cherry picked from commit 62766db) Service-Card-Id: 89230303 Service-Version: 1.17
Some of these were reundant, and some didn't feel right when I read them. Oh, and I got rid of all of these particularly unhelpful or non-additive resources: ``` Color Scheme [ v ] Is a color scheme ``` (cherry picked from commit 62766db) Service-Card-Id: 89230304 Service-Version: 1.18
Some of these were reundant, and some didn't feel right when I read them.
Oh, and I got rid of all of these particularly unhelpful or non-additive resources:
The only one I am truly iffy about is the one that newly says
OSC 2.