Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a "Move Tab to New Window" tab context menu item #15376

Merged
merged 7 commits into from
May 25, 2023

Conversation

Jaswir
Copy link
Contributor

@Jaswir Jaswir commented May 17, 2023

Summary of the Pull Request

Add the "Move Tab to New Window" item to the context menu of the tabs

References and Relevant Issues

#15127

Detailed Description of the Pull Request / Additional comments

Add the "Move Tab to New Window" item to the context menu of the tabs.
Detailed_description_of_commit_PR1

Validation Steps Performed

Checked Code Style
https://github.com/microsoft/terminal/blob/main/doc/STYLE.md

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 17, 2023
@github-actions

This comment has been minimized.

@DHowett
Copy link
Member

DHowett commented May 17, 2023

@Jaswir thanks so much for working on this! We are busy preparing for Microsoft's developer conference, so we might be a little slower than usual to respond. Don't worry -- we're really excited to review your code!

@zadjii-msft was on vacation until recently, which is why he's been less quick to respond. Somebody is on the repository every day, typically, but it's hard to get our attention on any individual issue sometimes. That's my fault. 😄

@Jaswir

This comment was marked as resolved.

@Jaswir
Copy link
Contributor Author

Jaswir commented May 18, 2023

@DHowett

:O What conference?

@zadjii-msft
Copy link
Member

@DHowett

:O What conference?

Microsoft Build, which is kinda the biggest conference for us.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, this all looks good. Just fix up those typos ☺️

src/cascadia/TerminalApp/Resources/en-US/Resources.resw Outdated Show resolved Hide resolved
Comment on lines 833 to 834
<data name="MoveTabtoNewWindowToolTip" xml:space="preserve">
<value>Moves tab to a new window using the active profile in the current directory</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<data name="MoveTabtoNewWindowToolTip" xml:space="preserve">
<value>Moves tab to a new window using the active profile in the current directory</value>
<data name="MoveTabToNewWindowToolTip" xml:space="preserve">
<value>Moves tab to a new window</value>
  1. Capitalize the To to make the bot happy
  2. I'd suggest removing the "using the active profile in the current directory" - that would seemingly imply that a new tab is created, when really, the current tab is just moving to the new window, connection and all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get point 2:
"using the active profile in the current directory."
I interpreted this to mean that the current tab information (active profile in current directory) is used for the tab you want to move. And so you don't create a new tab, but move the current tab (using the active profile in the current directory) to the new window.

src/cascadia/TerminalApp/TerminalTab.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/TerminalTab.cpp Outdated Show resolved Hide resolved
@Jaswir
Copy link
Contributor Author

Jaswir commented May 18, 2023

@zadjii-msft

Can I somehow change the typos inside here?

image

Just choose, accept suggestion or something?

Jaswir and others added 3 commits May 18, 2023 15:28
Accept suggestion ??? Is this possible?

Co-authored-by: Mike Griese <migrie@microsoft.com>
Suggestion Accepted??

Co-authored-by: Mike Griese <migrie@microsoft.com>
Accept suggestion

Co-authored-by: Mike Griese <migrie@microsoft.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Jaswir
Copy link
Contributor Author

Jaswir commented May 18, 2023

@zadjii-msft
There you go, adapted changes.

@zadjii-msft zadjii-msft changed the title Dev/jaswir Add support for a "Move Tab to New Window" tab context menu item May 18, 2023
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jaswir
Copy link
Contributor Author

Jaswir commented May 19, 2023

@zadjii-msft

You're welcome

@Jaswir Jaswir closed this May 22, 2023
@Jaswir Jaswir deleted the dev/jaswir branch May 22, 2023 09:35
@Jaswir Jaswir restored the dev/jaswir branch May 22, 2023 09:44
@Jaswir
Copy link
Contributor Author

Jaswir commented May 22, 2023

@zadjii-msft
Uhm I accidentally screwed up. Didn't know deleting my forked branch would close this issue...

@Jaswir Jaswir reopened this May 22, 2023
@Jaswir
Copy link
Contributor Author

Jaswir commented May 22, 2023

@zadjii-msft

Ah I think I fixed it. But you'll need to review it again, sorry.

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label May 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label May 22, 2023
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f5a703c into microsoft:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "Move Tab to New Window" item to the context menu of the tabs
4 participants