AGAIN, intentionally leak our App, so that we DON'T crash on exit #15451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Issue-Bug
DHowett
approved these changes
May 26, 2023
DHowett
pushed a commit
that referenced
this pull request
May 26, 2023
…5451) This is a resurrection of #5629. As it so happens, this crash-on-exit was _not_ specific to my laptop. It's a bug in the XAML platform somewhere, only on Windows 10. In #14843, we moved this leak into `becomeMonarch`. Turns out, we don't just need this leak for the monarch process, but for all of them. It's not a real "leak", because ultimately, our `App` lives for the entire lifetime of our process, and then gets cleaned up when we do. But `dtor`ing the `App` - that's apparently a no-no. Was originally in #15424, but I'm pulling it out for a super-hotfix release. Closes #15410 MSFT:35761869 looks like it was closed as no repro many moons ago. This should close out our hits there (firmly **40% of the crashes we've gotten on 1.18**) (cherry picked from commit aa8ed8c) Service-Card-Id: 89332890 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resurrection of #5629. As it so happens, this crash-on-exit was not specific to my laptop. It's a bug in the XAML platform somewhere, only on Windows 10.
In #14843, we moved this leak into
becomeMonarch. Turns out, we don't just need this leak for the monarch process, but for all of them.It's not a real "leak", because ultimately, our
Applives for the entire lifetime of our process, and then gets cleaned up when we do. Butdtoring theApp- that's apparently a no-no.Was originally in #15424, but I'm pulling it out for a super-hotfix release.
Closes #15410
MSFT:35761869 looks like it was closed as no repro many moons ago. This should close out our hits there (firmly 40% of the crashes we've gotten on 1.18)