AtlasEngine: Fix support for font features #15912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
commented
Aug 31, 2023
| @@ -648,6 +648,9 @@ void AtlasEngine::_flushBufferLine() | |||
|
|
|||
| const auto initialIndicesCount = row.glyphIndices.size(); | |||
|
|
|||
| // GetTextComplexity() returns as many glyph indices as its textLength parameter (here: mappedLength). | |||
| // This block ensures that the buffer has sufficient capacity. It also initializes the glyphProps buffer because it and | |||
| // glyphIndices sort of form a "pair" in the _mapComplex() code and are always simultaneously resized there as well. | |||
There was a problem hiding this comment.
-> Suppress whitespace changes: https://github.com/microsoft/terminal/pull/15912/files?w=1
zadjii-msft
approved these changes
Aug 31, 2023
DHowett
approved these changes
Aug 31, 2023
DHowett
pushed a commit
that referenced
this pull request
Sep 22, 2023
Font features require us to skip the fast path via `GetTextComplexity`. `IDWriteTextLayout` handles it the same way internally. Closes #15896 ## Validation Steps Performed * Use Cascadia Code * Set `features: { "ss19": 1 }` * "0" has a dash in it instead of a dot ✅ (cherry picked from commit 5fb2518) Service-Card-Id: 90380016 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font features require us to skip the fast path via
GetTextComplexity.IDWriteTextLayouthandles it the same way internally.Closes #15896
Validation Steps Performed
features: { "ss19": 1 }