Don't end the current mark, if we get one of the same kind #16107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're already in the "output" state, then an app requesting an "output" mark probably shouldn't end the current mark and start a new one. It should just keep on keepin' on. The decision to end the previous one was arbitrary in the first place, so let's arbitrarily change it back. Especially noticable if you hit <kbd>Enter</kbd> during a command, because the auto-mark prompt work will do a CommandEnd, so long-running commands will get broken into multiple marks 🥲
lhecker
approved these changes
Oct 9, 2023
carlos-zamora
approved these changes
Oct 11, 2023
DHowett
pushed a commit
that referenced
this pull request
Jan 29, 2024
If you're already in the "output" state, then an app requesting an "output" mark probably shouldn't end the current mark and start a new one. It should just keep on keepin' on. The decision to end the previous one was arbitrary in the first place, so let's arbitrarily change it back. Especially noticable if you hit <kbd>Enter</kbd> during a command, because the auto-mark prompt work will do a CommandEnd, so long-running commands will get broken into multiple marks 🥲 (cherry picked from commit 0144cdd) Service-Card-Id: 91707294 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're already in the "output" state, then an app requesting an "output" mark probably shouldn't end the current mark and start a new one. It should just keep on keepin' on.
The decision to end the previous one was arbitrary in the first place, so let's arbitrarily change it back.
Especially noticable if you hit Enter during a command, because the auto-mark prompt work will do a CommandEnd, so long-running commands will get broken into multiple marks 🥲