Fix scrollbar resetting position on save #16261
Conversation
microsoft-github-policy-service
bot
added
Issue-Bug
This comment was marked as resolved.
This comment was marked as resolved.
radu-cernatescu
force-pushed
the
settings-fix
branch
3 times, most recently
from
96ab360 to
9845623
Compare
|
Can we get rid of all the other |
|
Actually hold up, I'm pretty sure that this will result in every page having two scrollbars when "Always show scrollbars" is on in the OS settings: |
radu-cernatescu
force-pushed
the
settings-fix
branch
2 times, most recently
from
95c427d to
f3e7ce0
Compare
|
This feels a lot better! Thanks for getting rid of the inner There's one issue I noticed; perhaps you have an idea how to fix it. If you open a profile page, and then navigate to "Advanced" (or another sub-page), it remembers the scroll position from the previous page. It results in the list of options being cut off at the top. |
|
My apologies with the weird force pushing, I will resolve my branch as soon as possible. As for the sub pages, @DHowett, I have the fix, (just need to scroll up when navigating to them) just got my branch a little messed up. |
radu-cernatescu
force-pushed
the
settings-fix
branch
from
f3e7ce0 to
032f760
Compare
|
@DHowett,@zadjii-msft,@lhecker : I have fixed the sub pages as well and tested the application. Everything looks good to me now. Let me know if anything is missing or if there's any feedback! Thanks again everyone. |
Fix overlapping disclaimer text in Profiles' Defaults section In #16261, when we removed ScrollViewer from the subpages in the settings UI, the main Grid child element order was not preserved and as a result, the disclaimer text overlapped with the main content on the page. To fix that we now apply (the lost) `Grid.Row` property on the parent StackPanel of the main content. ### Validation Steps Performed - Disclaimer text does not overlap. ### PR Checklist - [x] Tests added/passed
Summary of the Pull Request
This PR fixes Issue #11875 by introducing a ScrollViewer and some logic for the scrollbar.
Detailed Description of the Pull Request / Additional comment
The ScrollViewer prevents the scrollbar from scrolling to the top whenever "Save" is clicked in the Settings. In addition, the scrollbar is scrolled to the top of the page whenever navigating to another page within Settings. The scrollbar will not reset if attempting to navigate to the same page that is already navigated to.
Validation Steps Performed
Manual testing of the Settings by building the Terminal app.
PR Checklist