Fix dwControlKeyState always including ENHANCED_KEY #16335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
|
/cc @j4james for this one 😄 |
|
I hate this. If it were up to me I would reject this PR. |
|
I removed |
j4james
reviewed
Nov 18, 2023
j4james
reviewed
Nov 18, 2023
lhecker
changed the title
DHowett
reviewed
Nov 21, 2023
lhecker
force-pushed
the
dev/lhecker/16266-bad-enum
branch
from
240bfb0 to
9c50a03
Compare
DHowett
approved these changes
Nov 21, 2023
zadjii-msft
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Huh. This is curious to me, because that line of code dates back to like, 2018:
https://github.com/microsoft/terminal/blame/2e26c3e0c958f174d838049ce43cbb7dc52eb7e8/src/terminal/parser/InputStateMachineEngine.cpp#L733
So, I wouldn't really expect it to be a recent regression... But if it works, it works.
|
(is the current description up-to-date? I think that confused me here) |
FYI, the reason why it wasn't a problem initially is because that state wasn't actually used anywhere until the change made here: |
DHowett
pushed a commit
that referenced
this pull request
Dec 4, 2023
Since all VT parameters are treated to be at least 1 (and 1 if they're absent or 0), `modifierParam > 0` was always true. This meant that `ENHANCED_KEY` was always being set. It's unclear why `ENHANCED_KEY` was used there, but it's likely not needed in general. Closes #16266 ## Validation Steps Performed * Can't test this unless we fix the win32 input mode issue #16343 ❌ (cherry picked from commit be9fc20) Service-Card-Id: 91159301 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all VT parameters are treated to be at least 1 (and 1 if they're
absent or 0),
modifierParam > 0was always true. This meant thatENHANCED_KEYwas always being set. It's unclear whyENHANCED_KEYwas used there, but it's likely not needed in general.
Closes #16266
Validation Steps Performed