COOKED_READ: Fix tab not erasing the prompt #16718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Feb 15, 2024
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
carlos-zamora and
DHowett
zadjii-msft
approved these changes
Feb 21, 2024
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
pushed a commit
that referenced
this pull request
Feb 21, 2024
Write "<command that doesn't exist> foo" in cmd.exe, move yours cursor past the <command> and press tab. The "foo" will still be there but will be inaccessible. This commit fixes the issue. As far as I can tell, this never worked in any conhost version ever. Closes #16704 (cherry picked from commit 5e9f223) Service-Card-Id: 91851715 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Feb 21, 2024
Write "<command that doesn't exist> foo" in cmd.exe, move yours cursor past the <command> and press tab. The "foo" will still be there but will be inaccessible. This commit fixes the issue. As far as I can tell, this never worked in any conhost version ever. Closes #16704 (cherry picked from commit 5e9f223) Service-Card-Id: 91851714 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write "<command that doesn't exist> foo" in cmd.exe, move yours cursor
past the and press tab. The "foo" will still be there but
will be inaccessible. This commit fixes the issue. As far as I can
tell, this never worked in any conhost version ever.
Closes #16704