Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Settings Model tests into proper CI tests #16773

Merged
merged 39 commits into from
Feb 29, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Feb 27, 2024

This pull request removes the need for the SettingsModel tests to run in
a UAP harness and puts them into the standard CI rotation.

This required some changes to Run-Tests.ps1 to ensure that the right
te.exe is selected for each test harness. It's a bit annoying, but for
things that depend on a resources.pri, that file must be in the same
directory as the EXE that is hosting the test. Not the DLL, mind you,
the EXE. In our case, that's TE.ProcessHost.exe

The bulk of the change is honestly namespace tidying.

DHowett and others added 30 commits April 24, 2022 15:41
@DHowett DHowett changed the title reviewn't Make the Settings Model tests into proper CI tests Feb 27, 2024
@DHowett DHowett marked this pull request as ready for review February 27, 2024 19:18
@DHowett
Copy link
Member Author

DHowett commented Feb 27, 2024

It is important to note that these tests currently fail, because one of the profile tests has been broken since #15843 (very recently! this PR will prevent future regressions!) and one is broken on the test agent due to long file paths. Ha.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now if only this worked with the TerminalApp ones too, oh man would that be sweet

@DHowett
Copy link
Member Author

DHowett commented Feb 28, 2024

I'd like to merge these green :)

@zadjii-msft would you be able to look into the profile icon failure?

@lhecker would you mind looking at the commandline normalization failure? We have seen smth like this before

@lhecker
Copy link
Member

lhecker commented Feb 28, 2024

expected: C:\Users\SHINET~1\AppData\Local\Temp\be8dba0d-abb9-45b0-b352-cdf6dea84b45 two\file 2.exe
actual: C:\Users\ShineTest\AppData\Local\Temp\be8dba0d-abb9-45b0-b352-cdf6dea84b45 two\file 2.exe

The good news is that the path normalization worked! The bad news is that the CI's username is too long.

@DHowett
Copy link
Member Author

DHowett commented Feb 28, 2024

@lhecker yay! that worked! Now it's just Mike's 🥲

@zadjii-msft
Copy link
Member

Done. I absolutely adore that these can run in CI now

@zadjii-msft zadjii-msft enabled auto-merge (squash) February 29, 2024 16:09
@DHowett DHowett disabled auto-merge February 29, 2024 16:59
@DHowett DHowett merged commit 30dbd3b into main Feb 29, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/what-if-localtests-didnt branch February 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants