Add OriginTag to Command #16823
Merged
Add OriginTag to Command #16823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Mar 5, 2024
zadjii-msft
approved these changes
Mar 8, 2024
lhecker
approved these changes
Mar 18, 2024
Comment on lines
+69
to
+70
| static com_ptr<ActionMap> FromJson(const Json::Value& json, const OriginTag origin = OriginTag::None); | ||
| std::vector<SettingsLoadWarnings> LayerJson(const Json::Value& json, const OriginTag origin, const bool withKeybindings = true); |
There was a problem hiding this comment.
Does the origin need to be an optional parameter? If it weren't we could ensure we never forget to pass the right tag.
There was a problem hiding this comment.
So the reason for this is in SerializationTests.cpp we call FromJson on several different classes (Profile, ActionMap, etc) in a template function, and not all have them take OriginTag as a parameter. We should fix those tests to not behave like this and make origin a non-optional parameter, but I'm fine with leaving that as a follow up
PankajBhojwani
added
the
AutoMerge
|
@zadjii-msft @lhecker could you re-approve? It says the reviews are stale |
zadjii-msft
approved these changes
Mar 19, 2024
microsoft-github-policy-service
bot
deleted the
dev/pabhoj/action_origin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As outlined in #16816 , adding
OriginTagtoCommandis one of the prerequisites to implementing Action IDs. This PR does that.Validation Steps Performed
Actions/Commands still get parsed and work
PR Checklist