-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .rc
files in TSM instead of string literals
#16844
Conversation
src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj
Show resolved
Hide resolved
src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.Model.rc
Outdated
Show resolved
Hide resolved
For some reason the tests are unable to load the settings the new way, they throw this exception: |
Remember! Settings Tests is a separate DLL that consumes the Settings static library. It doesn't know about the |
nit: make sure your PR title is short (72 characters is a great maximum) and descriptive, and that the body is up to date and complete. |
If you want to follow the style for my commit messages, you can remove the headings and the empty checkboxes. |
(and final nit: it's not instead of powershell scripts, it's instead of string literals!) |
.rc
files in TSM instead of powershell scripts to generate the default strings needed.rc
files in TSM instead of string literals
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
More prerequisite work for Action IDs - turns out if we add the action IDs to the actions defined in
defaults.json
the string ends up being too large and the compiler complains about it. Use a.rc
file fordefaults.json
instead and also forenableColorSelection.json
+userDefaults.json
.