Add SettingContainer Warning/Error styles to replace InfoBar #16876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some styles to SettingContainer that can be used to display informational messages. They don't have reset buttons or content and they can't be interacted with. I did this because the InfoBars didn't scale properly when the window was wide. Also they had an [X] button that hid the warning but didn't persist that they had been hidden or anything.
|
|
DHowett
changed the title
lhecker
approved these changes
Mar 14, 2024
|
Closes #16354 iirc |
Alas, it actually doesn't. I didn't do anything to change the existing warnings, since Leonard is about to blow them up anyway. |
zadjii-msft
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some styles to SettingContainer that can be used to display informational messages. They don't have reset buttons or content and they can't be interacted with.
I did this because the InfoBars didn't scale properly when the window was wide. Also they had an [X] button that hid the warning but didn't persist that they had been hidden or anything.