Add more profile GUID tests #17030
Merged
Add more profile GUID tests #17030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Apr 8, 2024
| VERIFY_IS_FALSE(profile2->HasGuid()); | ||
| VERIFY_IS_TRUE(profile3->HasGuid()); | ||
| VERIFY_IS_TRUE(profile4->HasGuid()); | ||
| // The following crash JSON parsing |
There was a problem hiding this comment.
FWIW, this should throw an exception which you can verify you caught with VERIFY_THROWS!
There was a problem hiding this comment.
I wasn't sure if they should crash so I left them as comment, now they are using VERIFY_THROWS (thanks for mentioning that!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adding more profile GUID tests
References and Relevant Issues
Closes #2119
Detailed Description of the Pull Request / Additional comments
Currently, there are formats that simply break GUID parsing (the commented out test cases). Should we catch that and treat it like a "null" GUID or should we generate a new GUID for those profiles?
Validation Steps Performed
PR Checklist