Fix window style under minimized state #17058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
|
Oh wow, great catch! Is this because when we go from Max to Min we change the height of the TabRowControl/MinMaxCloseControl? |
|
Oh, I see it now. Thanks @tusharsnx and @j4james for the investigation :) |
DHowett
approved these changes
Apr 16, 2024
lhecker
approved these changes
Apr 16, 2024
DHowett
pushed a commit
that referenced
this pull request
Apr 22, 2024
Closes: #13961 This PR changes the window styling we use under the minimized state. We now retain the active window styling so the content's height doesn't change when switching between minimized and maximized states. ## Validation Steps Performed - Open Terminal and go into Maximized mode. - Click on the Minimize button. - No `SizeChanged` event in `ControlCore`. - Click on the WT icon in the taskbar to restore it. - No `SizeChanged` event in `ControlCore`. (cherry picked from commit 11c4aa4) Service-Card-Id: 92350318 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Apr 22, 2024
Closes: #13961 This PR changes the window styling we use under the minimized state. We now retain the active window styling so the content's height doesn't change when switching between minimized and maximized states. ## Validation Steps Performed - Open Terminal and go into Maximized mode. - Click on the Minimize button. - No `SizeChanged` event in `ControlCore`. - Click on the WT icon in the taskbar to restore it. - No `SizeChanged` event in `ControlCore`. (cherry picked from commit 11c4aa4) Service-Card-Id: 92350319 Service-Version: 1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13961
This PR changes the window styling we use under the minimized state. We now retain the active window styling so the content's height doesn't change when switching between minimized and maximized states.
Validation Steps Performed
SizeChangedevent inControlCore.SizeChangedevent inControlCore.