Fix font axes/features settings UI #17164
Conversation
| #include "EnumEntry.h" | ||
| #include "ProfileViewModel.h" | ||
|
|
||
| #include "Appearances.g.cpp" |
There was a problem hiding this comment.
Welcome to the doomsday diff. This was awful to write, so I'm sure it's going to be awful to read.
doc/cascadia/profiles.schema.json
Outdated
| @@ -349,7 +349,7 @@ | |||
| "description": "Sets the DWrite font features for the given font. For example, { \"ss01\": 1, \"liga\":0 } will enable ss01 and disable ligatures.", | |||
| "type": "object", | |||
| "patternProperties": { | |||
| "^(([A-Za-z0-9]){4})$": { | |||
| "^[\\x00-\\x7E]{4}$": { | |||
There was a problem hiding this comment.
leonard you're scaring me
are there opentype features that we were excluding from pleasant company?
... should we keep excluding them?
There was a problem hiding this comment.
When implementing the corresponding C++ code for this, I checked the OpenType and CSS 4 docs. Tags are apparently any 4 letter printable ASCII, so I changed the code and schema accordingly.
There was a problem hiding this comment.
"printable" would start at \x20 right?
There was a problem hiding this comment.
Oh wow, I didn't notice that typo at all! Thanks!
| @@ -731,6 +731,16 @@ namespace Microsoft::Terminal::Settings::Model::JsonUtils | |||
|
|
|||
| Json::Value ToJson(const float val) | |||
| { | |||
| // Convert floats that are almost integers to proper integers, because that looks way neater in JSON. | |||
|
|
||
| --*/ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
HAHAH line endings strikes again
Can you confirm whether this is correct? UNFORTUNATELY, our repo stores CRLF internally.
There was a problem hiding this comment.
It seems it's the other way around. These files are LF in our repo and I accidentally turned this file into CRLF.
There was a problem hiding this comment.
I've rebased it now with Appearances.{idl,h,cpp} converted to LF endings.
Edit: No changes https://github.com/microsoft/terminal/compare/41a3df2c03c0a37c8b875396967c0b2142d11d44..0077ed72800e360bdf1500754c0c0257a10f57f5?w=1
| void AxisKeyValuePair::AxisIndex(int32_t axisIndex) | ||
| // You can't return a const-ref from a WinRT function, because the cppwinrt generated wrapper chokes on it. | ||
| // So, now we got two KeyDisplayString() functions, because I refuse to AddRef/Release this for no reason. | ||
| // I mean, really it makes no perf. difference, but I'm not kneeling down for an incompetent code generator. |
lhecker
force-pushed
the
dev/lhecker/16943-sui-axes
branch
from
41a3df2 to
0077ed7
Compare
Due to #16821 everything about #16104 broke. This PR rights the wrongs
by rewriting all the
Font-based code to not useFontat all.Instead we split the font spec once into font families, do a lot of
complex logic to split font axes/features into used and unused ones
and construct all the UI elements. So. much. boilerplate. code.
Closes #16943
Validation Steps Performed
There are more edge cases than I can list here... Some ideas: