Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining buffer serialization bugs #17182

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented May 2, 2024

It may be more accurate to say: "Fix known remaining buffer
serialization bugs", but I'll try to be positive about my code.

Initially, the buffer is initialized with the default attributes,
but once it begins to scroll, newly scrolled in rows are initialized
with the current attributes. This means we need to set the current
attributes to those of the upcoming row before the row comes up.

This is related to #17074.

Validation Steps Performed

  • Persist and restore a buffer 10 times
  • All previous "Restore" status messages look correct ✅
  • The escape sequences in the buffer file look correct ✅

@lhecker lhecker added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels May 2, 2024
@zadjii-msft
Copy link
Member

Does this actually close #17074 now?

@DHowett DHowett merged commit d4faf98 into main May 2, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/17074-fixup branch May 2, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants