Make sure DCS strings are flushed to conpty without delay #17195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have a better plan for fixing this, feel free to reject this PR. I just wanted to offer this as a potential solution in case nobody else gets around to looking at it in the short term. |
lhecker
approved these changes
May 6, 2024
DHowett
approved these changes
May 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DHowett
pushed a commit
that referenced
this pull request
May 6, 2024
When the `DCS` passthrough code was first implemented, it relied on the `ActionPassThroughString` method flushing the given string immediately. However, that has since stopped being the case, so `DCS` operations end up being delayed until the entire sequence has been parsed. This PR fixes the issue by introducing a `flush` parameter to force an immediate flush on the `ActionPassThroughString` method, as well as the `XtermEngine::WriteTerminalW` method that it calls. ## Validation Steps Performed I've confirmed that the test case in issue #17111 now updates the color table as soon as each color entry is parsed, instead of delaying the updates until the end of the sequence. Closes #17111 (cherry picked from commit 9c16c5c) Service-Card-Id: 92501226 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
DCSpassthrough code was first implemented, it relied on theActionPassThroughStringmethod flushing the given string immediately.However, that has since stopped being the case, so
DCSoperations endup being delayed until the entire sequence has been parsed.
This PR fixes the issue by introducing a
flushparameter to force animmediate flush on the
ActionPassThroughStringmethod, as well as theXtermEngine::WriteTerminalWmethod that it calls.Validation Steps Performed
I've confirmed that the test case in issue #17111 now updates the color
table as soon as each color entry is parsed, instead of delaying the
updates until the end of the sequence.
Closes #17111