Remove spaces from snippets in the SXNUI #17261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
lhecker
approved these changes
May 13, 2024
| @@ -964,17 +965,32 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation | |||
| cmdImpl.copy_from(winrt::get_self<implementation::Command>(command)); | |||
|
|
|||
| const auto inArgs{ command.ActionAndArgs().Args().try_as<Model::SendInputArgs>() }; | |||
|
|
|||
| const auto inputString{ (std::wstring_view)(inArgs ? inArgs.Input() : L"") }; | |||
There was a problem hiding this comment.
Technically you need to assign the Input() to somewhere before getting a weak string-view to it. It's not guaranteed that the implementation of the property holds onto a reference of the HSTRING after all.
There was a problem hiding this comment.
I'm gonna block over this, since it could be an easy safety issue
carlos-zamora
approved these changes
May 13, 2024
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple different issues:
Before in blue:
closes #16577
closes #16578