Fix a cooked read deadlock #17905
Merged
Fix a cooked read deadlock #17905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
commented
Sep 11, 2024
| if (col > columnLimit) | ||
| { | ||
| columns = columnLimit; | ||
| return dist; |
There was a problem hiding this comment.
I removed this code because I moved the line-wrap check into _layoutLine. I felt like that it made it more robust and easier to understand.
lhecker
force-pushed
the
dev/lhecker/17893-cooked-deadlock
branch
from
a10f66b to
03e953a
Compare
carlos-zamora
approved these changes
Sep 12, 2024
DHowett
approved these changes
Sep 24, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 24, 2024
Because `_layoutLine` would never return `column == columnLimit` for control character visualizers, we'd get a deadlock in `_redisplay`, as it tries to fill the line until it's full, but never achieve it. Closes #17893 ## Validation Steps Performed * Press Ctrl-A to insert "^A" * Press Home to get to the start of the prompt * Press and hold "A" until the line wraps * The line wraps and there's no deadlock ✅ (cherry picked from commit 0ce654e) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTEJwI Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
_layoutLinewould never returncolumn == columnLimitforcontrol character visualizers, we'd get a deadlock in
_redisplay,as it tries to fill the line until it's full, but never achieve it.
Closes #17893
Validation Steps Performed