Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open current working directory action. #18013

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Open current working directory action. #18013

merged 4 commits into from
Dec 5, 2024

Conversation

michaeljsXu
Copy link
Contributor

Summary of the Pull Request

Added open current directory action.

References and Relevant Issues

Need to set this: https://learn.microsoft.com/en-us/windows/terminal/tutorials/new-tab-same-directory

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Ensure shell has been configured
  • Run "Open current working directory" action in command palette
  • File explorer opens the correct directory

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Oct 8, 2024
@michaeljsXu
Copy link
Contributor Author

@microsoft-github-policy-service agree

@lhecker
Copy link
Member

lhecker commented Dec 4, 2024

Oh, it seems this PR fell off our radar...

@lhecker lhecker added the Needs-Second It's a PR that needs another sign-off label Dec 4, 2024
PankajBhojwani
PankajBhojwani approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@PankajBhojwani PankajBhojwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label Dec 5, 2024
@zadjii-msft zadjii-msft merged commit 7cdf9ee into microsoft:main Dec 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@DHowett DHowett Awaiting requested review from DHowett

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an action to "Open in File Explorer"
4 participants
@michaeljsXu @lhecker @zadjii-msft @PankajBhojwani