Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enterprises to disable Terminal Chat or only enable select LMs #18095

Merged
merged 120 commits into from
Oct 29, 2024

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

Adds registry keys to allow enterprises to disable Terminal Chat or only enable certain LMs

Notes:

  • If the policy is not set at all, all LM providers are allowed
  • If the policy is set, we look at the provided allow list to determine which LMs (if any) should be allowed
  • Only the allowed LMs show up in the AI Settings page to allow for configuration
  • If no LMs are allowed, the Terminal Chat action is not shown in the new tab dropdown nor the command palette and existing keybindings to open Terminal Chat are not handled
  • Regardless of the policy, any keybindings/modifications to a user's toggle terminal chat action are preserved

Validation Steps Performed

Toggling the policy/updating the allow list updates the settings page, dropdown and command palette appropriately

PR Checklist

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Love the way you display status 😊

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tour de force

nguyen-dows added a commit to MicrosoftDocs/terminal that referenced this pull request Oct 28, 2024
Addresses microsoft/terminal#18095 and
microsoft/terminal#18009

---------

Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Base automatically changed from dev/pabhoj/featurellm_capi to feature/llm October 28, 2024 23:18
An error occurred while trying to automatically change base from dev/pabhoj/featurellm_capi to feature/llm October 28, 2024 23:18
DHowett and others added 4 commits October 28, 2024 18:22
# Conflicts:
#	src/cascadia/TerminalSettingsEditor/AISettingsViewModel.h
#	src/cascadia/TerminalSettingsEditor/AISettingsViewModel.idl
#	src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
@DHowett DHowett enabled auto-merge (squash) October 29, 2024 00:24
@DHowett DHowett disabled auto-merge October 29, 2024 01:36
@DHowett DHowett merged commit 438621f into feature/llm Oct 29, 2024
19 of 21 checks passed
@DHowett DHowett deleted the dev/pabhoj/featurellm_registry_enable branch October 29, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants