-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Move Tab' submenu to tab context menu #18107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Area-Accessibility
Issues related to accessibility
Product-Terminal
The new Windows Terminal.
labels
Oct 24, 2024
lhecker
approved these changes
Oct 24, 2024
zadjii-msft
approved these changes
Oct 31, 2024
DHowett
reviewed
Oct 31, 2024
@@ -941,4 +944,10 @@ | |||
<data name="CloseSnippetsPaneButton.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip" xml:space="preserve"> | |||
<value>Close pane</value> | |||
</data> | |||
</root> | |||
<data name="TabMoveLeft" xml:space="preserve"> | |||
<value>Move left</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer "Move tab left" and "Move tab right" personally, but in the absence of other opinions i can stand down
Elenore23
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
DHowett
pushed a commit
that referenced
this pull request
Nov 18, 2024
## Summary of the Pull Request Adds a "Move tab" submenu to the tab's context menu. This submenu includes "move tab to new window", "move left", and "move right". The new "move left/right" items are disabled if the tab can't be moved in a certain direction.' Closes #17900 (cherry picked from commit d8089e9) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgU6Yu8 Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Accessibility
Issues related to accessibility
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a "Move tab" submenu to the tab's context menu. This submenu includes "move tab to new window", "move left", and "move right".
The new "move left/right" items are disabled if the tab can't be moved in a certain direction.'
Closes #17900