-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtlasEngine: Better builtin glyphs #18179
Conversation
cc @grable0 (I apologize to "grable" without "0" for pinging them accidentally.) (Ignore the different brightness in the middle. That's just a different theme.) |
That looks real nice 😃 But i suspect a lot of the same people who complained about aliasing probably wont like this change.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this - and in the future if the parameters become adjustable that's OK too!
Hey @lhecker, how does it look at 100% scale using a UI like, say, Far Manager or MC? I am worried about the very thick lines, but maybe that is not a necessary concern... |
This slightly modifies the builtin glyph width and corner radius to more closely match Cascadia Mono. Previously, at low DPI (100% scale), the corner radius was barely noticeable which looked kind of bad. (cherry picked from commit a8e83c1) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgU6YuY Service-Version: 1.22
So, I'll be that guy again 😅 – is there any option to turn this off? The double-lined box was more subtle, which I liked more than the current thick line. |
The lack of pixels on low DPI displays makes this a very difficult choice. The difference between very thin and too fat is literally just 1px. The ideal solution is for Microsoft to mandate OEMs sell high DPI displays 5-10 years ago. If you think about it, especially when looking at what Apple sells at scale for almost the same price, it's honestly a complete rip-off. (And it affects me too...) In any case, I tested it on an 1440p display I own, and I personally found the thicker lines to be easier to read, even if I found them to be significantly less "stylish". Because of that I went with this approach in the end. We'll see if there's a lot of people that will complain about this. If there are too many, I'll revert it. The issue to follow to make this a setting is #18180. It's not a difficult change to make and help with it is wanted, because I probably won't get to it within the next few months. |
I won't complain like "on no, it's broken beyond repair", but the new lines look slightly overpronounced and it feels like they distract attention from the actual content (at least for this particular font size): It could be due to the fact that these lines contrast perfectly with the background, unlike the text of roughly the same thickness with all the curves and antialiasing and smoothing, so it could make sense to have them slightly thinner than the text and jump from 1 to 2 pixels slightly later. |
This slightly modifies the builtin glyph width and corner radius to
more closely match Cascadia Mono. Previously, at low DPI (100% scale),
the corner radius was barely noticeable which looked kind of bad.