build: change how we find the latest VC tools version #18468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, we were using the package containing the CRT _source code_ to determine the version of the tools. We should use the version of the tools package instead.
lhecker
approved these changes
Jan 28, 2025
carlos-zamora
approved these changes
Jan 28, 2025
DHowett
added a commit
that referenced
this pull request
Jan 28, 2025
Apparently, we were using the package containing the CRT _source code_ to determine the version of the tools. Also apparently, VS does not guarantee that that package has the same version as the tools package. We should use the version of the tools package instead. (cherry picked from commit 8e4da6e) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgWyLAQ Service-Version: 1.22
DHowett
added a commit
that referenced
this pull request
Jan 28, 2025
Apparently, we were using the package containing the CRT _source code_ to determine the version of the tools. Also apparently, VS does not guarantee that that package has the same version as the tools package. We should use the version of the tools package instead. (cherry picked from commit 8e4da6e) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgWyLAM Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we were using the package containing the CRT source code to determine the version of the tools.
Also apparently, VS does not guarantee that that package has the same version as the tools package.
We should use the version of the tools package instead.