Add Badge to highlight new Extensions Page #18813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Demo
|
carlos-zamora
added a commit
that referenced
this pull request
Apr 18, 2025
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/beautify
branch
from
f650f45 to
b963d60
Compare
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/badge
branch
from
5c34eb7 to
641b654
Compare
lhecker
reviewed
Apr 22, 2025
lhecker
reviewed
Apr 22, 2025
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/beautify
branch
from
b963d60 to
f25e6fe
Compare
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/badge
branch
from
641b654 to
87946e9
Compare
Member
Author
|
Based on @cinnamon-msft's work over in microsoft/PowerToys#36939:
|
DHowett
reviewed
Apr 22, 2025
| </data> | ||
| <data name="NewInfoBadgeTextBlock.Text" xml:space="preserve"> | ||
| <value>NEW</value> | ||
| <comment>Text is used on an info badge for new navigation items. Must be all caps.</comment> |
Member
There was a problem hiding this comment.
I do not believe the translators actually read these. or exist.
Member
There was a problem hiding this comment.
I think it may be beneficial for us long-term if we replaced the comments with ones like
"NEW" as in "New item!"
in this case. Even if there aren't always human translators, the potential LLM translators may be "thankful"? for it. 😅
lhecker
approved these changes
Apr 23, 2025
Base automatically changed from
dev/cazamor/sui/ext-page/beautify
to
dev/cazamor/sui/extensions-page
April 24, 2025 22:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a badge to the Extensions Page in the SUI's navigation pane to highlight that it's new!
References and Relevant Issues
Targets #18633
Detailed Description of the Pull Request / Additional comments
ApplicationStateclass to track which badges have been dismissed and prevent them from appearing againstd::unordered_set, but exposed agetandappendfunction via the IDLNewInfoBadgestyle that is just an InfoBadge with "NEW" in it instead of a number or an icon. Based on Add "new" labels to navigation PowerToys#36939getcall to theApplicationStateconducted via theExtensionsPageViewModel. The VM is also responsible for updating the state.Long-term, we can reuse this system and make the following minor changes:
SettingContainer: display the badge. and add logic to read/writeApplicationStateappropriately (similarly to above)XPageViewModel:NewInfoBadgestyleValidation Steps Performed
✅ Extensions page nav item displays a badge if page hasn't been visited
✅ The badge is dismissed when the user visits the page