Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes link to go to latest ColorTool release #2027

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Changes link to go to latest ColorTool release #2027

merged 1 commit into from
Jul 19, 2019

Conversation

WSLUser
Copy link
Contributor

@WSLUser WSLUser commented Jul 18, 2019

Summary of the Pull Request

Since ColorTool shares the same Release page as Windows Terminal, it is more difficult to navigate to it. So whenever ColorTool is updated with a new release, we will update the link to the latest release. The link I changed to is the latest available from April 2019. @zadjii-msft and @miniksa please review. This also came up in #2025.

References

PR Checklist

  • Closes ColorTool is missing in store version of Terminal #2025
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed N/A
  • Requires documentation to be updated - This is a doc update.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

N/A

Validation Steps Performed

Link works in updated README

Since ColorTool shares the same Release page as Windows Terminal, it is more difficult to navigate to it. So whenever ColorTool is updated with a new release, we will update the link to the latest release. The link I changed to is the latest available from April 2019. @zadjii-msft and @miniksa please review. This also came up in #2025.
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, good catch!

@DHowett-MSFT DHowett-MSFT merged commit dca0ffe into microsoft:master Jul 19, 2019
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
Since ColorTool shares the same Release page as Windows Terminal, it is more difficult to navigate to it. So whenever ColorTool is updated with a new release, we will update the link to the latest release. The link I changed to is the latest available from April 2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants