Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arbitrary args in keybindings #3391

Merged
merged 21 commits into from
Nov 14, 2019
Merged

Add support for arbitrary args in keybindings #3391

merged 21 commits into from
Nov 14, 2019

Commits on Oct 29, 2019

  1. this is a start, but there's a weird linker bug if I take the SetKeyb… 

    …inding(ShortcutAction, KeyChord) implementation out, which I don't totally understand
    @zadjii-msft
    zadjii-msft committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    2bb524c View commit details
    Browse the repository at this point in the history

  2. a good old-fashioned clean will fix that right up

    @zadjii-msft
    zadjii-msft committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8799451 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. all these things work

    @zadjii-msft
    zadjii-msft committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    d93a0bc View commit details
    Browse the repository at this point in the history

  2. hey this actually _functionally_ works

    @zadjii-msft
    zadjii-msft committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    e9a809b View commit details
    Browse the repository at this point in the history

  3. Mostly cleanup and completion of implementation

    @zadjii-msft
    zadjii-msft committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    26d9035 View commit details
    Browse the repository at this point in the history

  4. Hey I bet we could just make NewTab the handler for NewTabWithProfile

    @zadjii-msft
    zadjii-msft committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    4e43186 View commit details
    Browse the repository at this point in the history

  5. Start writing tests for Keybinding args

    @zadjii-msft
    zadjii-msft committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    9f426a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Add tests

    @zadjii-msft
    zadjii-msft committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    03a6486 View commit details
    Browse the repository at this point in the history

  2. Revert a bad sln change, and clean out dead code

    @zadjii-msft
    zadjii-msft committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    7ce59ba View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Merge branch 'master' into dev/migrie/f/1142-arbitrary-args

    @zadjii-msft
    zadjii-msft committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    14f942b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/1142-a… 

    …rbitrary-args

# Conflicts:
#	src/cascadia/TerminalApp/AppKeyBindings.idl
#	src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp
    @zadjii-msft
    zadjii-msft committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    64a4a4f View commit details
    Browse the repository at this point in the history

  3. Change to include "command" as a single object 

      This is a change to make @DHowett-MSFT happy. Changes the args to be a part
  of the "command" object, as opposed to an object on their own.

  EX:

  ```jsonc

    // Old style
    { "command": "switchToTab0", "keys": ["ctrl+1"] },
    { "command": { "action": "switchToTab", "index": 0 }, "keys": ["ctrl+alt+1"] },

    // new style
    { "command": "switchToTab0", "keys": ["ctrl+1"] },
    { "command": "switchToTab", "args": { "index": 0 } "keys": ["ctrl+alt+1"] },

  ```
    @zadjii-msft
    zadjii-msft committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    17087d7 View commit details
    Browse the repository at this point in the history

  4. schemas are hard yo

    @zadjii-msft
    zadjii-msft committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    adf9698 View commit details
    Browse the repository at this point in the history

  5. Fix the build?

    @zadjii-msft
    zadjii-msft committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    8623279 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. wonder why my -Wall settings are different than CI...

    @zadjii-msft
    zadjii-msft committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    6cb6eba View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/1142-a… 

    …rbitrary-args
    @zadjii-msft
    zadjii-msft committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    01b8c8f View commit details
    Browse the repository at this point in the history

  3. this makes me hate things

    @zadjii-msft
    zadjii-msft committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    fb0c987 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Comments from PR 

      * Add a `Direction::None`
  * LOAD BEARING
  * add some GH ids to TODOs
    @zadjii-msft
    zadjii-msft committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d47db70 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dev/migrie/f/1142-arbitrary-args

    @zadjii-msft
    zadjii-msft committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0c67298 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. add a comment

    @zadjii-msft
    zadjii-msft committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fed692c View commit details
    Browse the repository at this point in the history

  2. PR nits from carlos

    @zadjii-msft
    zadjii-msft committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d78560a View commit details
    Browse the repository at this point in the history