Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate WSL distributions for docker-desktop* #4156

Merged
2 commits merged into from
Jan 9, 2020
Merged

Conversation

DHowett-MSFT
Copy link
Contributor

These utility distributions are used by Docker for Windows' WSL2
integration. They are not intended for user consumption.

There is a minimal chance that a user has a distribution named docker-desktop or some superstring thereof, but this is taken as an acceptable level of risk.

These utility distributions are used by Docker for Windows' WSL2
integration. They are not intended for user consumption.

Fixes #3556.
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Jan 9, 2020
@DHowett-MSFT
Copy link
Contributor Author

@zadjii-msft clear of blockers?

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 9, 2020
@ghost
Copy link

ghost commented Jan 9, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 8a21698 into master Jan 9, 2020
@ghost ghost deleted the dev/duhowett/wsl1 branch January 9, 2020 20:26
@ghost
Copy link

ghost commented Jan 14, 2020

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklist Docker for Windows WSL2 Service Machines
4 participants