Code

Convert Tab to a WinRT type#4350

Code

Merged

20 commits merged intomastermicrosoft/terminal:masterfrom dev/lelian/WinRTTabmicrosoft/terminal:dev/lelian/WinRTTabCopy head branch name to clipboardFeb 4, 2020

+634-487

Commits

Commits on Jan 22, 2020

• Tab is now a WinRT type, changed its shared_ptr self calls to get_weaks

  leonMSFT

  committed
  b9fa082

  Copy full SHA for b9fa082

Commits on Jan 23, 2020

• changed test case to use com_ptr outside the lambda to heed the warning

  leonMSFT

  committed
  ae2b0d5

  Copy full SHA for ae2b0d5

• added a comment to the observable getset property macro

  leonMSFT

  committed
  b132475

  Copy full SHA for b132475

• modified TerminalPage to use an ObservableVector of WinRT tabs

  leonMSFT

  committed
  1afe573

  Copy full SHA for 1afe573

Commits on Jan 27, 2020

• changing macro name, using winrt_callback macro, and changing RegisterTerminalEvents signature

  leonMSFT

  committed
  5718127

  Copy full SHA for 5718127

• resolving merge conflicts

  leonMSFT

  committed
  7aaed78

  Copy full SHA for 7aaed78

• formatting

  leonMSFT

  committed
  f608b3c

  Copy full SHA for f608b3c

• fixing build errors

  leonMSFT

  committed
  516c0de

  Copy full SHA for 516c0de

Commits on Jan 29, 2020

• incorporating PR comments

  leonMSFT

  committed
  091d953

  Copy full SHA for 091d953

• moving this const cast magic into a macro magic

  leonMSFT

  committed
  ff8ed26

  Copy full SHA for ff8ed26

• FORMATTING WHY

  leonMSFT

  committed
  30ea840

  Copy full SHA for 30ea840

Commits on Jan 31, 2020

• some more PR comments inc

  leonMSFT

  committed
  f66525e

  Copy full SHA for f66525e

• Merge branch 'dev/lelian/WinRTTab' of https://github.com/microsoft/terminal into dev/lelian/WinRTTab

  leonMSFT

  committed
  26b000c

  Copy full SHA for 26b000c

• merge conflicts

  leonMSFT

  committed
  8239539

  Copy full SHA for 8239539

• i should staple ctrl-k ctrl-d to my forehead

  leonMSFT

  committed
  392ffc1

  Copy full SHA for 392ffc1

Commits on Feb 1, 2020

• in the middle of some changes, it's failing though

  leonMSFT

  committed
  b396451

  Copy full SHA for b396451

Commits on Feb 3, 2020

• changing function signatures to NOT take reference

  leonMSFT

  committed
  0b447ba

  Copy full SHA for 0b447ba

Commits on Feb 4, 2020

• Update src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp

  Show description for ce4c2ac
  

  leonMSFT

  and

  carlos-zamora

  authored
  ce4c2ac

  Copy full SHA for ce4c2ac

• f o r m a t t i n g

  leonMSFT

  committed
  21b82c0

  Copy full SHA for 21b82c0

• overloading the function

  leonMSFT

  committed
  b920356

  Copy full SHA for b920356