til::point

[miniksa]

Summary of the Pull Request

Introduces convenience type til::point which automatically implements our best practices for point-related types and provides automatic conversions in/out of the relevant types.

PR Checklist

• In support of Differential Rendering Restore differential drawing to DirectWrite renderer #778
• I work here.
• Tests added/passed
• I'm a core contributor.

Detailed Description of the Pull Request / Additional comments

• Automatically converts in from anything with a X/Y (console COORD) or x/y (Win32 POINT)
• Automatically converts out to COORD, POINT, or D2D1_POINT_2F.
• Constructs from bare integers written into source file
• Default constructs to empty
• Uses Chromium Math for all basic math operations (+, -, *, /)
• Provides equality tests
• Accessors for x/y
• Type converting accessors (that use safe conversions and throw) for x/y
• TAEF/WEX Output and Comparators so they will print very nicely with VERIFY and Log macros in our testing suite.
• A natvis

Validation Steps Performed

• See automated tests of functionality.

[miniksa]

NOTE: This is going to look an awful lot like til::size (#4850) and that's on purpose. I want them to be completely separate types so they don't combine into each other in any way like COORD has historically done in our codebase in reference to both sizes and points. I also want to give them the opportunity to evolve separately if need be, say, if something like "area" makes sense for a size but not for a point.

[ghost]

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 22 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[miniksa]

@msftbot merge in 1 minute

[ghost]

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Fri, 13 Mar 2020 00:04:14 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".